qiuchenjian commented on a change in pull request #3106: [CARBONDATA-3276] Compacting table that do not exist should throw NoSuchTableException instead of MalformedCarbonCommandException URL: https://github.com/apache/carbondata/pull/3106#discussion_r256779065
########## File path: common/src/main/java/org/apache/carbondata/common/exceptions/sql/NoSuchCarbonTableException.java ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.carbondata.common.exceptions.sql; + +import org.apache.carbondata.common.annotations.InterfaceAudience; +import org.apache.carbondata.common.annotations.InterfaceStability; + [email protected] [email protected] +public class NoSuchCarbonTableException extends MalformedCarbonCommandException { + public NoSuchCarbonTableException(String db, String table) { Review comment: @manishgupta88 1. i think MalformedCarbonCommandException is not right, user will not know the real exception 2. the ddl is used for carbon, so i don't think we should pass the flow to hive 3. Do you think which is better? NoSuchTableException or NoSuchCarbonTableException , or some better suggests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
