ravipesala commented on a change in pull request #3126: [WIP][CARBONDATA-3293]
Prune datamaps improvement
URL: https://github.com/apache/carbondata/pull/3126#discussion_r258030456
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java
##########
@@ -54,6 +56,13 @@ void init(DataMapModel dataMapModel)
List<T> prune(Expression filter, SegmentProperties segmentProperties,
List<PartitionSpec> partitions, CarbonTable carbonTable) throws
IOException;
+ /**
+ * Prune the data maps for finding the row count. It returns a Map of
+ * blockletpath and the row count
+ */
+ Map<String, Integer> pruneRowCount(Segment segment, SegmentProperties
segmentProperties,
Review comment:
It is just getting row count, not pruning anything here so, please rename it
accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
