dhatchayani commented on a change in pull request #3153:
[TestCase][Hotfix]Added condition to check if datamap exist or not before
caching
URL: https://github.com/apache/carbondata/pull/3153#discussion_r267197645
##########
File path:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/TestCreateTableUsingSparkCarbonFileFormat.scala
##########
@@ -502,7 +504,9 @@ class TestCreateTableUsingSparkCarbonFileFormat extends
FunSuite with BeforeAndA
checkAnswer(spark.sql("SELECT COUNT(*) FROM (select address,age,note from
sdkOutputTableWithoutSchema where length(address)=75000 and
length(note)=75000)"),
Seq(Row(totalRecordsNum)))
spark.sql("DROP TABLE sdkOutputTableWithoutSchema")
- clearDataMapCache
+ val mapSize=DataMapStoreManager.getInstance().getAllDataMaps.size()
+ if(mapSize>0)
+ clearDataMapCache
Review comment:
please remove duplicate code.
please check if this code can be added inside "clearDataMapCache" method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
