kunal642 commented on a change in pull request #3172: [CARBONDATA-3341] fixed
invalid NULL result in filter query
URL: https://github.com/apache/carbondata/pull/3172#discussion_r272944582
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
##########
@@ -261,7 +261,12 @@ public int compareTo(int rowId, byte[] compareValue) {
// if the compare value is null and the data is also null we can
directly return 0
return 0;
} else {
- byte[] chunkData = this.getChunkDataInBytes(rowId);
+ byte[] chunkData;
+ if (nullBitSet != null && nullBitSet.length == 0) {
+ chunkData = nullBitSet;
+ } else {
+ chunkData = this.getChunkDataInBytes(rowId);
+ }
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
