ajantha-bhat commented on a change in pull request #2814: [CARBONDATA-3001] configurable page size in MB URL: https://github.com/apache/carbondata/pull/2814#discussion_r273797879
########## File path: core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java ########## @@ -31,6 +34,9 @@ private short rangeId; + /* key is complex column name, val is it's flat byte array */ + private Map<String, List<ArrayList<byte[]>>> complexFlatByteArrayMap; Review comment: This is an extracted data from `data` of `CarbonRow`. previously in `TablePage.java`, List<ArrayList<byte[]>> encodedComplexColumnar was extracted from `data` and using it, it was never modified actual `data`. So, I have used the same logic. Also modifying data[] with flat complex data may lead to many code changes where data[] is used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
