ajantha-bhat commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#discussion_r275632109
########## File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/binary/TestBinaryDataType.scala ########## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.carbondata.integration.spark.testsuite.binary + +import java.util.Arrays + +import org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.metadata.CarbonMetadata +import org.apache.carbondata.core.metadata.schema.table.CarbonTable +import org.apache.carbondata.core.util.CarbonProperties +import org.apache.commons.codec.binary.Hex +import org.apache.spark.sql.Row +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.BeforeAndAfterAll + +/** + * Test cases for testing binary + */ +class TestBinaryDataType extends QueryTest with BeforeAndAfterAll { + override def beforeAll { + } + + test("Create table and load data with binary column") { + sql("DROP TABLE IF EXISTS binaryTable") + sql( + s""" + | CREATE TABLE IF NOT EXISTS binaryTable ( + | id int, + | label boolean, + | name string, + | image binary, + | autoLabel boolean) + | STORED BY 'carbondata' + """.stripMargin) + sql( + s""" + | LOAD DATA LOCAL INPATH '$resourcesPath/binarydata.csv' + | INTO TABLE binaryTable + | OPTIONS('header'='false') + """.stripMargin) + checkAnswer(sql("SELECT COUNT(*) FROM binaryTable"), Seq(Row(3))) + try { + val df = sql("SELECT * FROM binaryTable").collect() + assert(3 == df.length) + df.foreach { each => + assert(5 == each.length) + + assert(Integer.valueOf(each(0).toString) > 0) + assert(each(1).toString.equalsIgnoreCase("false") || (each(1).toString.equalsIgnoreCase("true"))) + assert(each(2).toString.contains(".png")) + + val bytes20 = each.getAs[Array[Byte]](3).slice(0, 20) + val binaryName = each(2).toString + val expectedBytes = firstBytes20.get(binaryName).get + assert(Arrays.equals(expectedBytes, bytes20), "incorrect numeric value for flattened image") + + assert(each(4).toString.equalsIgnoreCase("false") || (each(4).toString.equalsIgnoreCase("true"))) + } + } catch { + case e: Exception => + e.printStackTrace() + assert(false) + } + } + + test("Support projection for binary") { + sql("DROP TABLE IF EXISTS binaryTable") Review comment: No need to create table and load data again again, can test this scenario in above test case also. Because more duplicate test steps, will slow down the PR builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
