xubo245 commented on a change in pull request #3173: [CARBONDATA-3351] Support 
Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r275648998
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java
 ##########
 @@ -521,6 +521,8 @@ private static int compareMeasureData(byte[] first, byte[] 
second, DataType data
         compare = -1;
       }
       return (int) compare;
+    } else if (dataType == DataTypes.BINARY) {
+      return 0;
 
 Review comment:
   ok, done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to