xubo245 commented on a change in pull request #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#discussion_r275828580
########## File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CSVCarbonWriter.java ########## @@ -65,7 +65,7 @@ @Override public void write(Object object) throws IOException { try { - writable.set((String[]) object); + writable.set((Object[]) object); Review comment: no need convert byte[] to string before write, and no need convert string to byte[] in carbon internal . No encode hex for byte[] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services