kumarvishal09 commented on a change in pull request #3182: [CARBONDATA-3343]
Compaction for Range Sort
URL: https://github.com/apache/carbondata/pull/3182#discussion_r277673106
##########
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
##########
@@ -495,7 +628,22 @@ class CarbonMergerRDD[K, V](
}
}
-
+ private def createOrderingForColumn(column: CarbonColumn): Ordering[Object]
= {
Review comment:
Same method is present
org.apache.carbondata.spark.load.DataLoadProcessBuilderOnSpark#createOrderingForColumn
, please move this to some utility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
