manishgupta88 commented on a change in pull request #3177:
[CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL: https://github.com/apache/carbondata/pull/3177#discussion_r277683489
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java
##########
@@ -91,43 +94,129 @@ public static DataMapJob getDataMapJob(Configuration
configuration) throws IOExc
* @param carbonTable
* @throws IOException
*/
- public static void executeDataMapJobForClearingDataMaps(CarbonTable
carbonTable)
- throws IOException {
- String dataMapJobClassName =
"org.apache.carbondata.spark.rdd.SparkDataMapJob";
+ private static void executeDataMapJobForClearingSegmentDataMaps(DataMapJob
dataMapJob,
+ CarbonTable carbonTable) throws IOException {
+ SegmentStatusManager.ValidAndInvalidSegmentsInfo
validAndInvalidSegmentsInfo =
+ getValidAndInvalidSegments(carbonTable,
FileFactory.getConfiguration());
+ List<String> invalidSegment = new ArrayList<>();
+ for (Segment segment : validAndInvalidSegmentsInfo.getInvalidSegments()) {
+ invalidSegment.add(segment.getSegmentNo());
+ }
+ DistributableDataMapFormat dataMapFormat = new
DistributableDataMapFormat(carbonTable, null,
Review comment:
Instead of passing null for not required field can we expose another
constructor to pass only the required non-null values and refactor the
constructors within the class. Also move the null fields as the last arguments
in the existing constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
