jackylk commented on a change in pull request #3177:
[CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL: https://github.com/apache/carbondata/pull/3177#discussion_r277921163
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapFactory.java
##########
@@ -111,9 +111,11 @@ public abstract DataMapBuilder createBuilder(Segment
segment, String shardName,
public abstract void fireEvent(Event event);
/**
- * Clears datamap of the segment
+ * Clear all datamaps for a segment from memory
*/
- public abstract void clear(Segment segment);
+ public void clear(String segmentNo) {
Review comment:
Unify the names, if it is number, it should be integer, if it is id, the
name should be segmentId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
