ravipesala commented on a change in pull request #3178: [CARBONDATA-3348]
Support alter SORT_COLUMNS property
URL: https://github.com/apache/carbondata/pull/3178#discussion_r277971837
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -488,7 +488,7 @@ private int getBlockCount(List<ExtendedBlocklet>
blocklets) {
// This is to log the event, so user will know what is happening by seeing
logs.
LOG.info("Started block pruning ...");
if (carbonTable.isTransactionalTable()) {
- prunedBlocklets = defaultDataMap.prune(segmentIds, resolver,
partitionsToPrune);
+ prunedBlocklets = defaultDataMap.prune(segmentIds, expression, resolver,
partitionsToPrune);
Review comment:
Better wrap `expression` and `resolver` to one object and send it to the
tabledatamap.
And also remove the else part method as all will fall to the same method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
