QiangCai commented on a change in pull request #3183: [CARBONDATA-3349] Show
sort_columns for each segment
URL: https://github.com/apache/carbondata/pull/3183#discussion_r279175326
##########
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
##########
@@ -145,6 +152,208 @@ object CarbonStore {
}
}
+ def showSegments(
+ limit: Option[String],
+ carbonTable: CarbonTable,
+ hadoopConf: Configuration,
+ showHistory: Boolean): Seq[Row] = {
+ val metaFolder = CarbonTablePath.getMetadataPath(carbonTable.getTablePath)
+ val loadMetadataDetailsArray = if (showHistory) {
+ SegmentStatusManager.readLoadMetadata(metaFolder) ++
+ SegmentStatusManager.readLoadHistoryMetadata(metaFolder)
+ } else {
+ SegmentStatusManager.readLoadMetadata(metaFolder)
+ }
+
+ if (loadMetadataDetailsArray.nonEmpty) {
+ var loadMetadataDetailsSortedArray = loadMetadataDetailsArray.sortWith {
(l1, l2) =>
+ java.lang.Double.parseDouble(l1.getLoadName) >
java.lang.Double.parseDouble(l2.getLoadName)
+ }
+ if (!showHistory) {
+ loadMetadataDetailsSortedArray = loadMetadataDetailsSortedArray
+ .filter(_.getVisibility.equalsIgnoreCase("true"))
+ }
+ if (limit.isDefined) {
+ val limitLoads = limit.get
+ try {
+ val lim = Integer.parseInt(limitLoads)
+ loadMetadataDetailsSortedArray =
loadMetadataDetailsSortedArray.slice(0, lim)
+ } catch {
+ case _: NumberFormatException =>
Review comment:
it is old code, already change to reuse code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
