ravipesala commented on a change in pull request #3179: [CARBONDATA-3338] 
Support Incremental DataLoad for MV Datamap[with single parent table]
URL: https://github.com/apache/carbondata/pull/3179#discussion_r279241328
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
 ##########
 @@ -351,6 +357,27 @@ public static boolean 
updateLoadMetadataWithMergeStatus(List<LoadMetadataDetails
           loadMetadataDetails.setMajorCompacted("true");
         }
 
+        if (DataMapUtil.isMVdatamapTable(carbonTable)) {
+          // If table is mv datamap table, then get segment mapping and set to 
extraInfo
+          DataMapSchema dataMapSchema = null;
+          try {
+            dataMapSchema = 
DataMapStatusManager.getDataMapSchema(carbonTable.getTableName()
+                .substring(0,
 
 Review comment:
   I feel it is not a good way to get the datamap name like this, better add 
the required information to tableproperty and get them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to