ravipesala commented on a change in pull request #3177: [CARBONDATA-3337][CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r279429856
########## File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java ########## @@ -136,23 +212,23 @@ private static DistributableDataMapFormat createDataMapJob(CarbonTable carbonTab * @return list of Extended blocklets after pruning */ public static List<ExtendedBlocklet> executeDataMapJob(CarbonTable carbonTable, - FilterResolverIntf resolver, List<Segment> validSegments, - DataMapExprWrapper dataMapExprWrapper, DataMapJob dataMapJob, - List<PartitionSpec> partitionsToPrune) throws IOException { - String className = "org.apache.carbondata.core.datamap.DistributableDataMapFormat"; - SegmentStatusManager.ValidAndInvalidSegmentsInfo validAndInvalidSegmentsInfo = - getValidAndInvalidSegments(carbonTable, validSegments.get(0).getConfiguration()); - List<Segment> invalidSegments = validAndInvalidSegmentsInfo.getInvalidSegments(); + FilterResolverIntf resolver, Configuration configuration, DataMapJob dataMapJob, Review comment: Remove configuration if not used ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services