ravipesala commented on a change in pull request #3177:
[CARBONDATA-3337][CARBONDATA-3306] Distributed index server
URL: https://github.com/apache/carbondata/pull/3177#discussion_r279640145
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
##########
@@ -315,33 +297,64 @@ public void clear(Segment segment) {
public synchronized void clear() {
if (segmentMap.size() > 0) {
for (String segmentId : segmentMap.keySet().toArray(new
String[segmentMap.size()])) {
- clear(new Segment(segmentId, null, null));
+ clear(segmentId);
}
}
}
- @Override
- public List<CoarseGrainDataMap> getDataMaps(DataMapDistributable
distributable)
+ @Override public List<String> getAllTableBlockletUniqueNames() {
Review comment:
Better return the cache size used by each datamap from here directly instead
of getting the index files and looking onto cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services