ravipesala commented on a change in pull request #3150: [CARBONDATA-3309] MV 
datamap supports Spark 2.1
URL: https://github.com/apache/carbondata/pull/3150#discussion_r282766997
 
 

 ##########
 File path: 
datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/util/SQLBuildDSL.scala
 ##########
 @@ -398,11 +398,12 @@ trait SQLBuildDSL {
               // it back.
               case ar: AttributeReference if ar == gid => GroupingID(Nil)
               case ar: AttributeReference if groupByAttrMap.contains(ar) => 
groupByAttrMap(ar)
-              case a@Cast(
-              BitwiseAnd(
-              ShiftRight(ar: AttributeReference, Literal(value: Any, 
IntegerType)),
-              Literal(1, IntegerType)), ByteType, None) if ar == gid =>
+              case a : Cast if a.dataType.isInstanceOf[ByteType] &&
 
 Review comment:
   Use the MatchCast

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to