[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1

[GitBox]

qiuchenjian commented on a change in pull request #3150: [CARBONDATA-3309] MV 
datamap supports Spark 2.1
URL: https://github.com/apache/carbondata/pull/3150#discussion_r284136864
 
 

 ##########
 File path: 
datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/AggregatePushDown.scala
 ##########
 @@ -106,12 +106,14 @@ trait AggregatePushDown { // self: ModularPlan =>
         } else {
           Map.empty[Int, (NamedExpression, Seq[NamedExpression])]
         }
-      case sum@AggregateExpression(Sum(Cast(expr, dataType, timeZoneId)), _, 
false, _)
-        if expr.isInstanceOf[Attribute] =>
-        val tAttr = 
selAliasMap.get(expr.asInstanceOf[Attribute]).getOrElse(expr)
+      case sum@AggregateExpression(Sum(child), _, false, _)
 
 Review comment:
   No，origin line 114 ```val sum1 = AggregateExpression(Sum(Cast(tAttr, 
dataType, timeZoneId)), sum.mode, false)``` use it, if we don't pass the 
timeZoneId,  some test case will fail, such as "test create datamap with left 
join with group by with filter"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services