zhxiaoping commented on a change in pull request #3209: [CARBONDATA-3373]
Optimize scenes with in numbers in SQL
URL: https://github.com/apache/carbondata/pull/3209#discussion_r285364873
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/MeasureColumnExecuterFilterInfo.java
##########
@@ -16,15 +16,29 @@
*/
package org.apache.carbondata.core.scan.filter.executer;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
public class MeasureColumnExecuterFilterInfo {
Object[] filterKeys;
+ Set filterKeysSet;
public void setFilterKeys(Object[] filterKeys) {
this.filterKeys = filterKeys;
}
+ public void setFilterKeysSet(Object[] filterKeys) {
+ this.filterKeysSet = new HashSet<Object>(Arrays.asList(filterKeys));
Review comment:
it must contain null, because when the case is sql with where field is
null, it will also run this code.
if we remove null value, it can not filter null value, and the result will
be wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
