ravipesala commented on a change in pull request #3135: [CARBONDATA-3303] Fix
that MV datamap return wrong results when using coalesce and less groupby
columns
URL: https://github.com/apache/carbondata/pull/3135#discussion_r285386590
##########
File path:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
##########
@@ -172,6 +172,17 @@ object MVHelper {
if (catalog.isMVWithSameQueryPresent(logicalPlan)) {
throw new UnsupportedOperationException("MV with same query present")
}
+
+ var expressionValid = true
+ modularPlan.transformExpressions {
+ case coal@Coalesce(_) =>
Review comment:
what about `sum(coalesce(id, 0))`, this should be supported while creating
MV otherwise we cannot create MV in this scenario, Please add testcase for this
as well and support it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
