dhatchayani commented on a change in pull request #3262: [CARBONDATA-3415] 
Merge index is not working for partition table. Merge index for partition table 
is taking significantly longer time than normal table.
URL: https://github.com/apache/carbondata/pull/3262#discussion_r291510308
 
 

 ##########
 File path: 
integration/spark-common/src/main/scala/org/apache/spark/rdd/CarbonMergeFilesRDD.scala
 ##########
 @@ -145,7 +169,7 @@ class CarbonMergeFilesRDD(
       if (isHivePartitionedTable) {
         CarbonLoaderUtil
           .mergeIndexFilesInPartitionedSegment(carbonTable, split.segmentId,
-            segmentFileNameToSegmentIdMap.get(split.segmentId))
+            segmentFileNameToSegmentIdMap.get(split.segmentId), 
split.partitionPath)
 
 Review comment:
   In case of partition table, for a segment we will be writing segment files 
for each of the partition as merge index is per partition of a segment. 
Finally, we will be merging all the segment files to a single segment file and 
the same will be updated to the table status. Same is used here. Executors will 
write the segment file for the partition it is handling, at last driver merge 
all these segment files of partition to a segment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to