xubo245 commented on a change in pull request #3251: [CARBONDATA-3408]
CarbonSession partition support binary data type
URL: https://github.com/apache/carbondata/pull/3251#discussion_r291875876
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
##########
@@ -426,10 +426,10 @@ public static boolean isValidEscapeSequence(String
escapeChar) {
}
public static boolean isValidBinaryDecoder(String binaryDecoderChar) {
- return binaryDecoderChar.equalsIgnoreCase(
- CarbonLoadOptionConstants.CARBON_OPTIONS_BINARY_DECODER_BASE64) ||
- binaryDecoderChar.equalsIgnoreCase(
- CarbonLoadOptionConstants.CARBON_OPTIONS_BINARY_DECODER_HEX) ||
+ return
CarbonLoadOptionConstants.CARBON_OPTIONS_BINARY_DECODER_BASE64.equalsIgnoreCase(
Review comment:
it will throw NPE if binaryDecoderChar is null. it should return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
