KanakaKumar commented on a change in pull request #3181: [CARBONDATA-3356]
Support decimal for json schema and Provide better exception for users to solve
problem when carbonData DataSource read SDK files with varchar
URL: https://github.com/apache/carbondata/pull/3181#discussion_r292777931
##########
File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Field.java
##########
@@ -80,6 +82,24 @@ public Field(String name, String type) {
this.type = DataTypes.DOUBLE;
} else if (type.equalsIgnoreCase("binary")) {
this.type = DataTypes.BINARY;
+ } else if (type.startsWith("decimal")) {
Review comment:
Please make it as type.toLowerCase.startsWith(...) to handle case
sensitivity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
