kumarvishal09 commented on a change in pull request #3281: [WIP]Index server
performance improvement
URL: https://github.com/apache/carbondata/pull/3281#discussion_r293677830
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -117,9 +117,16 @@
BlockletDataMapModel blockletDataMapInfo = (BlockletDataMapModel)
dataMapModel;
DataFileFooterConverter fileFooterConverter =
new DataFileFooterConverter(dataMapModel.getConfiguration());
- List<DataFileFooter> indexInfo = fileFooterConverter
- .getIndexInfo(blockletDataMapInfo.getFilePath(),
blockletDataMapInfo.getFileData(),
- blockletDataMapInfo.getCarbonTable().isTransactionalTable());
+ List<DataFileFooter> indexInfo = null;
+ if (blockletDataMapInfo.getIndexInfos() == null ||
blockletDataMapInfo.getIndexInfos()
+ .isEmpty()) {
+ indexInfo = fileFooterConverter
+ .getIndexInfo(blockletDataMapInfo.getFilePath(),
blockletDataMapInfo.getFileData(),
+ blockletDataMapInfo.getCarbonTable().isTransactionalTable());
+ } else {
+ // when index info is already read and converted to data file footer
object
+ indexInfo = blockletDataMapInfo.getIndexInfos();
Review comment:
Not required as we are not keeping model in memory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
