manishgupta88 commented on a change in pull request #3281: [WIP]Index server
performance improvement
URL: https://github.com/apache/carbondata/pull/3281#discussion_r293712517
##########
File path:
integration/spark2/src/main/scala/org/apache/carbondata/indexserver/DataMapJobs.scala
##########
@@ -118,7 +142,15 @@ class EmbeddedDataMapJob extends AbstractDataMapJob {
}
dataMapFormat.setTaskGroupId(taskGroupId)
dataMapFormat.setTaskGroupDesc(taskGroupDesc)
- IndexServer.getSplits(dataMapFormat).toList.asJava
+ val splits = try {
+ IndexServer.getSplits(dataMapFormat)
+ .getExtendedBlockets(dataMapFormat.getCarbonTable.getTablePath,
dataMapFormat.getQueryId)
+ } finally {
+ if (null != tmpFolder && !tmpFolder.delete()) {
+ LOGGER.info("Problem while deleting the temp directory" +
tmpFolder.getAbsolutePath)
Review comment:
1. change it to `Logger.error`
2. Add space after the constant message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
