kumarvishal09 commented on a change in pull request #3281: [WIP]Index server
performance improvement
URL: https://github.com/apache/carbondata/pull/3281#discussion_r295091691
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java
##########
@@ -168,23 +168,28 @@ public static void pruneSegments(List<Segment> segments,
List<ExtendedBlocklet>
static List<ExtendedBlocklet> pruneDataMaps(CarbonTable table,
FilterResolverIntf filterResolverIntf, List<Segment> segmentsToLoad,
- List<PartitionSpec> partitions, List<ExtendedBlocklet> blocklets) throws
IOException {
+ List<PartitionSpec> partitions, List<ExtendedBlocklet> blocklets,
+ DataMapChooser dataMapChooser) throws IOException {
+ if (null == dataMapChooser) {
Review comment:
there are multiple caller of this method because of this null check is added
here, to avoid null check in all the caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
