ravipesala commented on a change in pull request #3322: [WIP]Fixed NPE in
Concurrent query
URL: https://github.com/apache/carbondata/pull/3322#discussion_r302052291
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
##########
@@ -130,16 +137,32 @@ public int addSegmentProperties(CarbonTable carbonTable,
}
}
} else {
- synchronized
(getOrCreateTableLock(carbonTable.getAbsoluteTableIdentifier())) {
+ synchronized (getOrCreateTableLock(
+ segmentPropertiesWrapper.carbonTable.getAbsoluteTableIdentifier())) {
+
updateDeleteMap(segmentIdSetAndIndexWrapper.getSegmentPropertiesIndex(), -1);
Review comment:
It is better we can it only it is already present in delete map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
