kumarvishal09 commented on a change in pull request #3380: [CARBONDATA-3515] 
Limit local dictionary size to 10MB and allow configuration.
URL: https://github.com/apache/carbondata/pull/3380#discussion_r323187968
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
 ##########
 @@ -1789,4 +1789,30 @@ public static Boolean getQueryPrefetchEnable() {
       return !prefetchEnable.equalsIgnoreCase("false");
     }
   }
+
+  /**
+   * get local dictionary size threshold in mb.
+   *
+   * @return local dictionary size threshold in mb.
+   */
+  public static int getLocalDictionarySizeThresholdInMB() {
 
 Review comment:
   Every time parsing dictionary size property will not be good better to add 
while loading the carbon.properties 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to