jackylk commented on a change in pull request #3355: [HOTFIX] Improve select 
query after Update/Delete operation.
URL: https://github.com/apache/carbondata/pull/3355#discussion_r327133299
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/mutate/SegmentUpdateDetails.java
 ##########
 @@ -84,6 +88,21 @@ public SegmentStatus getSegmentStatus() {
     return this.segmentStatus;
   }
 
+  public Set<String> getDeltaFileStamps() {
+    return deltaFileStamps;
+  }
+
+  public void setDeltaFileStamp(String deltaFileStamp) {
 
 Review comment:
   ```suggestion
     public void addDeltaFileStamp(String deltaFileStamp) {
   ```
   
   It is better to call it `add` since internally it is adding to a set

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to