manishnalla1994 commented on a change in pull request #3427: [CARBONDATA-3562]
Fix for SDK filter queries not working when schema is given explicitly while
Add Segment
URL: https://github.com/apache/carbondata/pull/3427#discussion_r342497956
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
##########
@@ -200,8 +207,14 @@ private static boolean isColumnMatchesStruct(CarbonColumn
tableColumn, CarbonCol
}
carbonDimension =
CarbonTable.getCarbonDimension(tempColName.toString(), parentDimension);
if (carbonDimension != null) {
+ // In case of SDK the columnId and columnName is same and this check
will ensure for
+ // all the child columns that the table column name is equal to
query column name and
+ // table columnId is equal to table columnName
if (carbonDimension.getColumnSchema().getColumnUniqueId()
- .equalsIgnoreCase(queryColumn.getColumnId())) {
+ .equalsIgnoreCase(queryColumn.getColumnId()) || (
+ carbonDimension.getColumnSchema().getColumnUniqueId()
Review comment:
This is only for the case of struct matching, as was before, just added one
more check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
