ajantha-bhat commented on a change in pull request #3438:
[CARBONDATA-3531]Support load and query for MV timeseries and support multiple
granularity.
URL: https://github.com/apache/carbondata/pull/3438#discussion_r346208114
##########
File path:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala
##########
@@ -104,7 +105,8 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends
Rule[LogicalPlan] {
if (needAnalysis && catalog != null) {
val modularPlan =
catalog.mvSession.sessionState.rewritePlan(plan).withMVTable
if (modularPlan.find(_.rewritten).isDefined) {
- val compactSQL = modularPlan.asCompactSQL
+ var compactSQL = modularPlan.asCompactSQL
+ compactSQL = reWriteTheSQL(modularPlan, compactSQL)
Review comment:
only one argument `modularPlan` is enough ? compactSQL can be derived from
that inside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
