kevinjmh commented on a change in pull request #3444: [CARBONDATA-3581] Support
page level bloom filter
URL: https://github.com/apache/carbondata/pull/3444#discussion_r349419653
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/AbstractRawColumnChunk.java
##########
@@ -54,6 +55,15 @@ public AbstractRawColumnChunk(int columnIndex, ByteBuffer
rawData, long offSet,
this.length = length;
}
+ public ColumnPagesBloomFilter getPageBloomFilter() {
+ // page bloom is disabled for current column in this blocklet
+ if (!dataChunkV3.isSetPage_bloom_chunk()) {
+ return null;
+ } else {
Review comment:
if page bloom is disabled for current column, the page_bloom_chunk will be
NULL, no need to new a useless ColumnPagesBloomFilter object, and we still need
to decide whether the object is efftive for pruning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
