VenuReddy2103 commented on a change in pull request #3436:
[CARBONDATA-3548]Geospatial Support: Modified to create and load the table with
a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349877872
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java
##########
@@ -69,7 +69,12 @@ public RowParserImpl(DataField[] output,
CarbonDataLoadConfiguration configurati
DataField[] input = new DataField[fields.length];
inputMapping = new int[input.length];
int k = 0;
+ Boolean isNonSchemaPresent = false;
for (int i = 0; i < fields.length; i++) {
+ if (fields[i].getColumn().getSchemaOrdinal() == -1) {
+ isNonSchemaPresent = true;
+ continue;
+ }
Review comment:
This could have been the easiest thing to do for me :)
There was a reason to keep inputMapping for non schema columns to be at the
end. We can stop the row parse moment a non schema columns is encountered. We
have only 1 non schema columns at the moment though.
Anyway, have modified as suggested. I believe your comment applies to for
converter(`RowConverterImpl.convert()`) too. Have modified converter to run the
loop for 2. First iteration converts schema columns and second iteration
generates and converts for non schema columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
