Indhumathi27 commented on a change in pull request #3480: [HOTFIX] Do not touch 
MDT file when getting datamap schema
URL: https://github.com/apache/carbondata/pull/3480#discussion_r350542596
 
 

 ##########
 File path: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
 ##########
 @@ -97,7 +97,7 @@ public void saveSchema(DataMapSchema dataMapSchema) throws 
IOException {
   @Override
   public DataMapSchema retrieveSchema(String dataMapName)
       throws IOException, NoSuchDataMapException {
-    checkAndReloadDataMapSchemas(true);
+    checkAndReloadDataMapSchemas(false);
 
 Review comment:
   If there is no mdtFile present, then if we pass `touchFile` as false, then 
everytime `datamapSchemas` cache will be loaded from disk. I think it may 
impact the performance

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to