jackylk commented on a change in pull request #3476: [CARBONDATA-3593] Fix
TOTAL_BLOCKLET_NUM not right when blocklet filt…
URL: https://github.com/apache/carbondata/pull/3476#discussion_r351157986
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
##########
@@ -113,6 +113,10 @@ public boolean isScanRequired(DataRefNode dataBlock) {
.get(QueryStatisticsConstants.TOTAL_PAGE_SCANNED);
totalPagesScanned.addCountStatistic(QueryStatisticsConstants.TOTAL_PAGE_SCANNED,
totalPagesScanned.getCount() + dataBlock.numberOfPages());
+ QueryStatistic totalBlockletStatistic =
queryStatisticsModel.getStatisticsTypeAndObjMap()
Review comment:
`isScanRequired` is used to check whether this block is required to scan, if
it is returning false, we should not add the statistics.
I think the original code is correct, are you facing some problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
