zzcclp commented on a change in pull request #3485: [CARBONDATA-3596] Fix
exception when execute load data command or select sql on a table which
includes complex columns after execute 'add column' command
URL: https://github.com/apache/carbondata/pull/3485#discussion_r351751130
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
##########
@@ -148,8 +148,8 @@ public DictionaryBasedResultCollector(BlockExecutionInfo
blockExecutionInfos) {
// get the complex columns data of this row
fillComplexColumnDataBufferForThisRow();
for (int i = 0; i < queryDimensions.length; i++) {
- fillDimensionData(scannedResult, surrogateResult, noDictionaryKeys,
complexTypeKeyArray,
- comlexDimensionInfoMap, row, i);
+ fillDimensionData(queryDimensions[i], scannedResult, surrogateResult,
Review comment:
why it needs to handle the default values for the newly added complex
columns? Currently CarbonData can't support to add complex columns for table,
this pr just resolves the problem of adding non-complex columns for a table
which has complex columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
