ajantha-bhat commented on a change in pull request #3499: [CARBONDATA-3607]
Remove batch_sort feature
URL: https://github.com/apache/carbondata/pull/3499#discussion_r355502290
##########
File path:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionGlobalSortTestCase.scala
##########
@@ -939,7 +939,7 @@ class StandardPartitionGlobalSortTestCase extends
QueryTest with BeforeAndAfterA
assert(exMessage.getMessage.contains("day is not a valid partition column
in table default.partitionnocolumn"))
}
- ignore("data loading with default partition in static partition table with
batchsort") {
+ ignore("data loading with default partition in static partition table with
local_sort") {
sql("DROP TABLE IF EXISTS partitiondefaultbatchsort")
sql(
"""
Review comment:
Table name is still a batch sort, better to rename for readability.
looked for "batchsort" in the code. only this file and
TestCreateTableWithSortScope has this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
