zzcclp commented on a change in pull request #3509: [CARBONDATA-3618] Update
query should throw exception if key has more than one value
URL: https://github.com/apache/carbondata/pull/3509#discussion_r357949025
##########
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
##########
@@ -135,7 +136,22 @@ private[sql] case class CarbonProjectForUpdateCommand(
else {
Dataset.ofRows(sparkSession, plan)
}
-
+ // If more than one value present for the update key, should fail
the update
+ val ds =
dataSet.select(CarbonCommonConstants.CARBON_IMPLICIT_COLUMN_TUPLEID)
Review comment:
dataSet here includes all data which will be loaded, if the size of data
which are to be updated is huge, I think this check will impact update
performance.
It better check the count of updated data in
'CarbonIUDAnalysisRule.processUpdateQuery', before parse 'selectStmt' to
'selectPlan', for example:
line 115 in CarbonAnalysisRules.scala, check the count:
```
if (sparkSession.sql(selectStmt).count() > 1) {
throw exception
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
