jackylk commented on a change in pull request #3483: [CARBONDATA-3597] Support
Merge for SCD and CCD scenarios
URL: https://github.com/apache/carbondata/pull/3483#discussion_r360630554
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -732,11 +732,16 @@ public QueryModel createQueryModel(InputSplit
inputSplit, TaskAttemptContext tas
if (dataMapFilter != null) {
checkAndAddImplicitExpression(dataMapFilter.getExpression(), inputSplit);
}
- return new QueryModelBuilder(carbonTable)
+ QueryModel queryModel = new QueryModelBuilder(carbonTable)
.projectColumns(projectColumns)
.filterExpression(dataMapFilter)
.dataConverter(getDataTypeConverter(configuration))
.build();
+ String readDeltaOnly = configuration.get("readDeltaOnly");
Review comment:
please make `readDeltaOnly` a constant like other constants in line 103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
