ajantha-bhat commented on a change in pull request #3522:
[CARBONDATA-3609][CARBONDATA-3610] Remove preaggregate and timeseries datamap
URL: https://github.com/apache/carbondata/pull/3522#discussion_r360773888
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
##########
@@ -116,54 +116,35 @@
SegmentStatusManager segmentStatusManager = new
SegmentStatusManager(identifier,
readCommittedScope.getConfiguration());
SegmentStatusManager.ValidAndInvalidSegmentsInfo segments =
segmentStatusManager
- .getValidAndInvalidSegments(carbonTable.isChildTable(),
loadMetadataDetails,
+ .getValidAndInvalidSegments(carbonTable.isChildTableForMV(),
loadMetadataDetails,
this.readCommittedScope);
- // to check whether only streaming segments access is enabled or not,
- // if access streaming segment is true then data will be read from
streaming segments
- boolean accessStreamingSegments =
getAccessStreamingSegments(job.getConfiguration());
- if (getValidateSegmentsToAccess(job.getConfiguration())) {
- if (!accessStreamingSegments) {
- List<Segment> validSegments = segments.getValidSegments();
- streamSegments = segments.getStreamSegments();
- streamSegments = getFilteredSegment(job, streamSegments,
readCommittedScope);
- if (validSegments.size() == 0) {
- return getSplitsOfStreaming(job, streamSegments, carbonTable);
- }
- List<Segment> filteredSegmentToAccess =
- getFilteredSegment(job, segments.getValidSegments(),
readCommittedScope);
- if (filteredSegmentToAccess.size() == 0) {
- return getSplitsOfStreaming(job, streamSegments, carbonTable);
- } else {
- setSegmentsToAccess(job.getConfiguration(), filteredSegmentToAccess);
- }
- } else {
- List<Segment> filteredNormalSegments =
- getFilteredNormalSegments(segments.getValidSegments(),
Review comment:
getFilteredNormalSegments definition also we can remove, it is unused now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
