jackylk commented on a change in pull request #3530: [CARBONDATA-3629] Fix
Select query failure on aggregation of same column on MV
URL: https://github.com/apache/carbondata/pull/3530#discussion_r361770549
##########
File path:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVUtil.scala
##########
@@ -49,23 +49,28 @@ class MVUtil {
case select: Select =>
select.children.map {
case groupBy: GroupBy =>
- getFieldsFromProject(groupBy.outputList, groupBy.predicateList,
logicalRelation)
+ getFieldsFromProject(groupBy.outputList, groupBy.predicateList,
+ logicalRelation, groupBy.flagSpec)
case _: ModularRelation =>
- getFieldsFromProject(select.outputList, select.predicateList,
logicalRelation)
+ getFieldsFromProject(select.outputList, select.predicateList,
+ logicalRelation, select.flagSpec)
}.head
case groupBy: GroupBy =>
groupBy.child match {
case select: Select =>
- getFieldsFromProject(groupBy.outputList, select.predicateList,
logicalRelation)
+ getFieldsFromProject(groupBy.outputList, select.predicateList,
+ logicalRelation, select.flagSpec)
case _: ModularRelation =>
- getFieldsFromProject(groupBy.outputList, groupBy.predicateList,
logicalRelation)
+ getFieldsFromProject(groupBy.outputList, groupBy.predicateList,
+ logicalRelation, groupBy.flagSpec)
}
}
}
def getFieldsFromProject(outputList: Seq[NamedExpression],
predicateList: Seq[Expression],
- logicalRelation: Seq[LogicalRelation]): mutable.LinkedHashMap[Field,
DataMapField] = {
+ logicalRelation: Seq[LogicalRelation],
+ flagSpec: Seq[Seq[Any]]): mutable.LinkedHashMap[Field, DataMapField] = {
Review comment:
please add comment to describe parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
