jackylk commented on a change in pull request #3532: [CARBONDATA-3557] Write flink streaming data to partition table URL: https://github.com/apache/carbondata/pull/3532#discussion_r361796748
########## File path: integration/flink/src/main/java/org/apache/carbon/flink/CarbonWriter.java ########## @@ -17,10 +17,229 @@ package org.apache.carbon.flink; +import java.io.File; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.datastore.exception.CarbonDataWriterException; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema; +import org.apache.carbondata.core.statusmanager.StageInput; +import org.apache.carbondata.core.util.CarbonUtil; + +import org.apache.log4j.Logger; + /** * This class is a wrapper of CarbonWriter in SDK. * It not only write data to carbon with CarbonWriter in SDK, also generate segment file. */ -public abstract class CarbonWriter extends ProxyFileWriter<String> { +public abstract class CarbonWriter extends ProxyFileWriter<Object[]> { + + private static final Logger LOGGER = + LogServiceFactory.getLogService(CarbonS3Writer.class.getName()); Review comment: ```suggestion LogServiceFactory.getLogService(CarbonWriter.class.getName()); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services