ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605]
Remove global dictionary feature
URL: https://github.com/apache/carbondata/pull/3502#discussion_r361853242
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/resolverinfo/visitor/DictionaryColumnVisitor.java
##########
@@ -55,26 +54,22 @@ public void
populateFilterResolvedInfo(ColumnResolvedFilterInfo visitableObj,
} catch (FilterIllegalMemberException e) {
throw new FilterUnsupportedException(e);
}
- try {
- resolvedFilterObject = FilterUtil
- .getFilterValues(metadata.getTableIdentifier(),
metadata.getColumnExpression(),
- evaluateResultListFinal, metadata.isIncludeFilter());
- if (!metadata.isIncludeFilter() && null != resolvedFilterObject) {
- // Adding default surrogate key of null member inorder to not
display the same while
- // displaying the report as per hive compatibility.
- // first check of surrogate key for null value is already added then
- // no need to add again otherwise result will be wrong in case of
exclude filter
- // this is because two times it will flip the same bit
- if (!resolvedFilterObject.getExcludeFilterList()
-
.contains(CarbonCommonConstants.MEMBER_DEFAULT_VAL_SURROGATE_KEY)) {
- resolvedFilterObject.getExcludeFilterList()
- .add(CarbonCommonConstants.MEMBER_DEFAULT_VAL_SURROGATE_KEY);
- }
- Collections.sort(resolvedFilterObject.getExcludeFilterList());
+ resolvedFilterObject = FilterUtil
+ .getFilterValues(metadata.getTableIdentifier(),
metadata.getColumnExpression(),
+ evaluateResultListFinal, metadata.isIncludeFilter());
+ if (!metadata.isIncludeFilter() && null != resolvedFilterObject) {
+ // Adding default surrogate key of null member inorder to not display
the same while
+ // displaying the report as per hive compatibility.
+ // first check of surrogate key for null value is already added then
+ // no need to add again otherwise result will be wrong in case of
exclude filter
+ // this is because two times it will flip the same bit
+ if (!resolvedFilterObject.getExcludeFilterList()
+ .contains(CarbonCommonConstants.MEMBER_DEFAULT_VAL_SURROGATE_KEY))
{
+ resolvedFilterObject.getExcludeFilterList()
+ .add(CarbonCommonConstants.MEMBER_DEFAULT_VAL_SURROGATE_KEY);
}
- } catch (QueryExecutionException e) {
- throw new FilterUnsupportedException(e);
Review comment:
why this change ? Want to throw QueryExecutionException exception itself,
but this method many place throws FilterUnsupportedException itself
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
