akashrn5 commented on a change in pull request #3546: [CARBONDATA-3642] Add
column name in error msg when string length exceed 32000
URL: https://github.com/apache/carbondata/pull/3546#discussion_r363158993
##########
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
##########
@@ -53,24 +53,38 @@ import org.apache.carbondata.core.util.DataTypeUtil
import org.apache.carbondata.processing.exception.DataLoadingException
import org.apache.carbondata.processing.loading.FailureCauses
import
org.apache.carbondata.processing.loading.exception.CarbonDataLoadingException
+import org.apache.carbondata.processing.loading.model.CarbonLoadModel
import org.apache.carbondata.processing.util.CarbonDataProcessorUtil
import org.apache.carbondata.streaming.parser.FieldConverter
object CarbonScalaUtil {
private val LOGGER: Logger =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
- def getString(value: Any,
+ def getString(
+ row: Row,
+ idx: Int,
+ carbonLoadModel: CarbonLoadModel,
serializationNullFormat: String,
complexDelimiters: util.ArrayList[String],
timeStampFormat: SimpleDateFormat,
dateFormat: SimpleDateFormat,
isVarcharType: Boolean = false,
isComplexType: Boolean = false,
level: Int = 0): String = {
- FieldConverter.objectToString(value, serializationNullFormat,
complexDelimiters,
- timeStampFormat, dateFormat, isVarcharType = isVarcharType,
isComplexType = isComplexType,
- level)
+ try {
+ FieldConverter.objectToString(row.get(idx), serializationNullFormat,
complexDelimiters,
+ timeStampFormat, dateFormat, isVarcharType = isVarcharType,
isComplexType = isComplexType,
Review comment:
just pass `isVarcharType` and `isComplexType`, no need of equals
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
