QiangCai commented on a change in pull request #3561: [HOTFIX] Fix INSERT STAGE
footer read error
URL: https://github.com/apache/carbondata/pull/3561#discussion_r363614028
##########
File path:
core/src/main/java/org/apache/carbondata/core/reader/CarbonFooterReaderV3.java
##########
@@ -59,17 +55,20 @@ public FileFooter3 readFooterVersion3() throws IOException
{
thriftReader.open();
// If footer offset is 0, means caller does not set it,
- // so we read it from the end of the file
+ // so we read it from the index file
if (footerOffset == 0) {
Review comment:
if it needs to read the index, better to implement in another place where it
decides to read index or footer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
