Zhangshunyu commented on a change in pull request #3564: [CARBONDATA-3655]
Support set base64 string as struct<binary> field value
URL: https://github.com/apache/carbondata/pull/3564#discussion_r363706267
##########
File path:
streaming/src/main/scala/org/apache/carbondata/streaming/parser/FieldConverter.scala
##########
@@ -63,16 +66,22 @@ object FieldConverter {
case b: java.lang.Boolean => b.toString
case s: java.lang.Short => s.toString
case f: java.lang.Float => f.toString
- case bs: Array[Byte] => new String(bs,
- Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET))
+ case bs: Array[Byte] =>
+ if (isInsertFlow) {
+ Base64.getEncoder.encodeToString(bs)
Review comment:
could you pls add some comment here about the reason in case 'isInsertFlow'
use base64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
