niuge01 commented on a change in pull request #3564: [CARBONDATA-3655] Support
set base64 string as struct<binary> field value
URL: https://github.com/apache/carbondata/pull/3564#discussion_r364092501
##########
File path:
integration/flink/src/main/java/org/apache/carbon/flink/CarbonS3Writer.java
##########
@@ -54,20 +55,31 @@
) {
super(factory, identifier, table);
final Properties writerProperties =
factory.getConfiguration().getWriterProperties();
+ final Properties carbonProperties =
factory.getConfiguration().getCarbonProperties();
final String commitThreshold =
writerProperties.getProperty(CarbonS3Property.COMMIT_THRESHOLD);
this.writerFactory = new WriterFactory(table, writePath) {
@Override
protected org.apache.carbondata.sdk.file.CarbonWriter newWriter(
final Object[] row) {
try {
- return org.apache.carbondata.sdk.file.CarbonWriter.builder()
+ final CarbonWriterBuilder writerBuilder =
+ org.apache.carbondata.sdk.file.CarbonWriter.builder()
.outputPath(super.getWritePath(row))
.writtenBy("flink")
.withSchemaFile(CarbonTablePath.getSchemaFilePath(table.getTablePath()))
.withCsvInput()
- .withHadoopConf(configuration)
- .build();
+ .withHadoopConf(configuration);
+ for (String propertyName : carbonProperties.stringPropertyNames()) {
Review comment:
The withLoadOptions method requires all property are load option, but
carbonProperties may have some unsupported non-load option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
