jackylk commented on a change in pull request #3568: [CARBONDATA-3658] Prune
and Cache only Matched partitioned segments for filter on Partitioned table
URL: https://github.com/apache/carbondata/pull/3568#discussion_r365522014
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/SegmentPropertiesFetcher.java
##########
@@ -34,7 +35,7 @@
* @return
* @throws IOException
*/
- SegmentProperties getSegmentProperties(Segment segment)
+ SegmentProperties getSegmentProperties(Segment segment, List<PartitionSpec>
partitionSpecs)
Review comment:
suggest to add one more interface instead of modifying existing one, keep
both interface so that user can choose to use original one if no partition
pruning is required.
and please modify function description accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
