ajantha-bhat commented on a change in pull request #3580: [CARBONDATA-3665]
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368259071
##########
File path:
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
##########
@@ -43,10 +45,11 @@
private static final Logger LOGGER =
LogServiceFactory.getLogService(CarbonLRUCache.class.getName());
/**
- * Map that will contain key as table unique name and value as cache Holder
+ * Guava cache that holds key as table unique name and value as cache Holder
* object
*/
- private Map<String, Cacheable> lruCacheMap;
+ private Cache<String, Cacheable> lruCacheMap;
Review comment:
There are scenarios where cache of some table need to be maintained and
other tables can be dropped. **It will be good if we support table level
expiry.** and not clear all the cache when expire.
Drop meta cache DML is already supporting table level dropping , but it is
manual work now. If this can be handled by guava, it is great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
