ajantha-bhat commented on a change in pull request #3538: [WIP] Separate Insert
and load to later optimize insert.
URL: https://github.com/apache/carbondata/pull/3538#discussion_r369382408
##########
File path:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
##########
@@ -172,6 +342,7 @@ object DataLoadProcessBuilderOnSpark {
updateLoadStatus(model, partialSuccessAccum)
}
+
Review comment:
This is WIP PR, I will update you once ready.
I am making 3 flows. one of load, one of insert with converter, insert
without converter. I have duplicated code for this. Once all the test case is
fixed. I will extract common code from all 3 flows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
